Skip to content

[#6624] Update EmailVerification model regarding the help texts - #6633

Open
vaszig wants to merge 1 commit into
mainfrom
feature/6624-update-EmailVerification-model
Open

[#6624] Update EmailVerification model regarding the help texts#6633
vaszig wants to merge 1 commit into
mainfrom
feature/6624-update-EmailVerification-model

Conversation

@vaszig

@vaszig vaszig commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Closes #6624

Changes

  • Update the help texts regarding the new need to have email verification in Profile component too.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Checked new model fields are usable in the admin
    • Problem detection in the admin email digest is handled
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how
  • Documentation

    • Added documentation which describes the changes

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (6b437f3) to head (546d416).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6633   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         859      859           
  Lines       33312    33312           
  Branches     3004     3004           
=======================================
  Hits        32400    32400           
  Misses        603      603           
  Partials      309      309           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vaszig
vaszig requested a review from SonnyBA September 10, 2026 09:26
@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Sep 10, 2026
Comment thread src/openforms/submissions/models/email_verification.py Outdated

@SonnyBA SonnyBA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to squash the feedback commit before merging 👍

@vaszig

vaszig commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Don't forget to squash the feedback commit before merging 👍

I was going to to that in the backport only but I can do it here too!Thanks for the reminder!

When we first introduced the Email verification flow we did it only for
the Email component. Now, the need is for Profile component too so we
just updated the help text to be more cleat that the component key used
can be of various component types.
@vaszig
vaszig force-pushed the feature/6624-update-EmailVerification-model branch from 46d5420 to 546d416 Compare September 10, 2026 14:41
@vaszig vaszig mentioned this pull request Sep 10, 2026
9 tasks

@sergei-maertens sergei-maertens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this PR to the stable versions first (starting with 3.5, then 4.0 with makemigrations --merge and then main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Fix must be backported to stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update EmailVerification's model

3 participants